Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensuring supportedInterfaces property when quering nfts transactions #677

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Nov 16, 2023

Fixes #668

Description

The History Store was pre-fetching the last transactions and that action generates to fetch and cache the metadata for all contracts without the fix of restoring the supportedInterfaces property. Once in the caché they never get restored. Therefore to see the changes you need to clean your local caché to fetch all contract metadata again. This time, the fetch process ends with the fix so it ends up saving locally the correct version of the metadata.

Test scenarios

  • Clean your localstorage (F12 -> Aplication -> Clean Storage)
  • Login using the Team Account
  • Go to the inventory. You should see three of the ERC721 I made without that property

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Nov 16, 2023 that may be closed by this pull request
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 5ce3130
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/6556adb6ecd6aa0009243bbc
😎 Deploy Preview https://deploy-preview-677--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 5ce3130
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/6556adb6245c95000848d3d1
😎 Deploy Preview https://deploy-preview-677--wallet-develop-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Nov 16, 2023
@donnyquixotic donnyquixotic merged commit 9ce9943 into develop Nov 17, 2023
9 checks passed
@donnyquixotic donnyquixotic deleted the 668-some-nfts-are-not-shown-because-they-lack-an-attribute-2 branch November 17, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some NFTs are not shown because they lack an attribute.
3 participants